Skip to content

linalg: remove pure attr from procedures using openmp runtime #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 22, 2024
Merged

linalg: remove pure attr from procedures using openmp runtime #826

merged 1 commit into from
May 22, 2024

Conversation

perazz
Copy link
Member

@perazz perazz commented May 21, 2024 •
edited
Loading

Fix #825.

OpenMP runtime library routines may not be called from PURE or ELEMENTAL procedures.

cc: @jvdp1 @fortran-lang/stdlib

jvdp1
jvdp1 approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @perazz . I will merge it now as it is a minor fix.

@jvdp1 jvdp1 merged commit 32018f2 into fortran-lang:master May 22, 2024
@perazz perazz deleted the no_pure_openmp branch May 22, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

+1 more reviewer

@LaplaceSoda LaplaceSoda LaplaceSoda approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conflict between the pure function stdlib_iparam2stage and openmp
3 participants
@perazz @jvdp1 @LaplaceSoda